[PATCH] D76290: [lit] Allow passing extra commands to executeShTest

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 12:21:23 PDT 2020


delcypher accepted this revision.
delcypher added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/lit/tests/shtest-inject.py:1
+# Check that we can inject commands at the beginning of a ShTest using a custom
+# test format.
----------------
ldionne wrote:
> delcypher wrote:
> > These tests require an external shell. I don't know if that option is available on all the platforms where this test runs (e.g. Windows). Do you need to put a `REQUIRES: <something>` on this test?
> These tests follow the exact format of the other tests in this directory, so this must not be an issue. Can I commit this?
Ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76290/new/

https://reviews.llvm.org/D76290





More information about the llvm-commits mailing list