[PATCH] D76459: [SCCP] Use SimplifyBinOp for non-integer constant/expressions & overdef.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 11:16:59 PDT 2020


efriedma added a comment.

> By just passing a context with the DL, SimplifyBinOp should not try to get additional information from looking at definitions.

What context is legal to use here?



================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:989
+      if (isa<UndefValue>(C))
+        return;
+      return (void)markConstant(IV, &I, C);
----------------
Sort of orthogonal, but the thought occurred to me: should we be trying to use the "undef" lattice state here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76459/new/

https://reviews.llvm.org/D76459





More information about the llvm-commits mailing list