[PATCH] D76356: [AMDGPU] Introduce more scratch registers in the ABI.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 10:44:15 PDT 2020


rampitec added a comment.

In D76356#1939493 <https://reviews.llvm.org/D76356#1939493>, @cdevadas wrote:

> Thank you all for the comments.
>  I can see that there are concerns with the current split boundary (4 VGPRs together), considering the fact that we have wide VGPR uses in certain scenarios (image instructions).
>  But, like Matt mentioned, how frequently such scenarios occur?
>  Changing the split boundary to a large value would probably take away the whole purpose of this patch - reduce the CSR spills & try to ensure a better occupancy.


What will happen if you need to pass VReg_1024 into a function? It might not be a common case, but will it even work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76356/new/

https://reviews.llvm.org/D76356





More information about the llvm-commits mailing list