[PATCH] D76652: [AArch64][GlobalISel] Don't localize TLS G_GLOBAL_VALUEs on Darwin.

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 10:12:05 PDT 2020


volkan accepted this revision.
volkan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/localizer-arm64-tti.ll:68
+; For now, we check we don't localize at all. We could in theory make sure that
+; we don't localize into the middle of a call sequence instead.
+define i32 @darwin_tls() {
----------------
Maybe add a TODO to `AArch64TargetLowering::shouldLocalize`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76652/new/

https://reviews.llvm.org/D76652





More information about the llvm-commits mailing list