[PATCH] D76373: [LV] Replace stored value with a VPValue (NFCI)

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 09:39:28 PDT 2020


gilr marked 2 inline comments as done.
gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1106
+    // Mask is optional and therefore the last operand.
+    return IsMasked ? User.getOperand(User.getNumOperands() - 1) : nullptr;
+  }
----------------
fhahn wrote:
> Do we need the extra `IsMasked` operand?  Would it be sufficient to check the number of operands and use Load with 2 ops => has as mask, Store with 3 ops => has a mask?
Right, will replace it with a method.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76373/new/

https://reviews.llvm.org/D76373





More information about the llvm-commits mailing list