[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 252256.
SouraVX added a comment.

Addressed @jhenderson comments, Thanks a lot for this!

- Refactored the code based on comments.
- Empty `case MacroDWO:` is still there with FIXME, just for appeasing a build warning ` warning: enumeration value ‘MacroDWO’ not handled in switch [-Wswitch]`
- No regression found after check-all.

FIXME: might still look a bit misplaced(couple of spaces), but clang-format is doing that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/BinaryFormat/Dwarf.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-macinfo.s
  llvm/test/DebugInfo/X86/debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-dwarf64-debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-opcode_operands_table-debug-macro-v5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.252256.patch
Type: text/x-patch
Size: 24185 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200324/cec6729a/attachment-0001.bin>