[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 02:39:50 PDT 2020


grimar added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:1026
+    return symbol_iterator(SymbolRef(toDRI(DotDynSymSec, 0), this));
+  else
+    // Skip 0-index NULL symbol.
----------------
grimar wrote:
> > You do not need curly bracers and else after return. See the sample I've suggested above
> 
> This wasn't addressed. 
(the part about "else after return')


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081





More information about the llvm-commits mailing list