[PATCH] D75131: [llvm-objdump][XCOFF][AIX] Implement -r option

Mon Mar 23 15:48:54 PDT 2020

jasonliu marked an inline comment as done.
jasonliu added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-all.test:23
+CHECK:        Inputs/xcoff-section-headers.o:	file format aixcoff-rs6000
+CHECK:        Disassembly of section .text:
+CHECK:        00000000 <.text>:
----------------
hubert.reinterpretcast wrote:
> I think additional prefixes can be added for the `.text` part to common up the `-D -r` and the `-d -r`.
Common up for the two cases make sense as they are identical for 95% of the time right now, and does not need much effort to parse both of the them. 
Common up for all three cases and adding more prefix actually decrease the readability of the test case in my mind. 
So if people are not feeling strong about it, I'd prefer to leave it as it is. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131