[PATCH] D76639: Change X86RetpolineThunks from a MachineFunctionPass to a ModulePass

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a comment.

I don't see any compelling reason to refactor this pass as extensively as this. I would prefer a patch that's a non functional change while appropriately renames the pass and other things used by the retpoline thunks pass so future readers of the code know the pass emits non-retpoline thunks as well as retpolines. That would also mean you could apply the integrated LVI/retpoline patch from before almost as-is on top of that refactor.

I think the original pass works well enough as implemented for LVI/SESES purposes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76639/new/

https://reviews.llvm.org/D76639