[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 14:11:20 PDT 2020


manojgupta added a comment.

Thanks,

Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval.



================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1110
   PTO.SLPVectorization = CodeGenOpts.VectorizeSLP;
+  PTO.CallGrpahProfile = CodeGenOpts.CallGraphProfile;
   PTO.Coroutines = LangOpts.Coroutines;
----------------
Typo: PTO.CallGrpahProfile -> PTO.CallGraphProfile


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1518
   Conf.PTO.SLPVectorization = CGOpts.VectorizeSLP;
+  Conf.PTO.CallGrpahProfile = CGOpts.CallGraphProfile;
 
----------------
Same typo.


================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:111
+  /// true.
+  bool CallGrpahProfile;
 };
----------------
CallGrpahProfile -> CallGraphProfile


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62627/new/

https://reviews.llvm.org/D62627





More information about the llvm-commits mailing list