[PATCH] D76611: [SCCP] Use ranges for predicate info conditions.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

(Lint has a couple formatting suggestions.)



================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:1274
 
-      if (CmpOp0 != CopyOf)
+      // If the original value is a constant we cannot do better.
+      LatticeVal OriginalVal = getValueState(CopyOf);
----------------
"If the original value is a constant we cannot do better" is technically not true; in theory, if we prove a contradiction, the ssa.copy is unreachable.  But unlikely to matter in practice, I guess.


================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:1299
+      LatticeVal &IV = ValueState[I];
+      if (CopyOf->getType()->isIntegerTy()) {
+        auto NewCR =
----------------
Do we want to try to handle the case where we have a constant expression of integer type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76611/new/

https://reviews.llvm.org/D76611