[PATCH] D75471: [AlignmentFromAssumptions] Fix a SCEV assertion resulting from address space differences.

[Richard Diamond via Phabricator via llvm-commits]

DiamondLovesYou marked 3 inline comments as done.
DiamondLovesYou added a comment.

Sorry for the delay; yes this is still active.



================
Comment at: llvm/test/Transforms/AlignmentFromAssumptions/amdgpu-crash.ll:3
+; RUN: opt < %s -alignment-from-assumptions -S | FileCheck %s
+; RUN: opt < %s -passes=alignment-from-assumptions -S | FileCheck %s
+
----------------
jdoerfert wrote:
> If you want to test for "non-crash", remove the FileCheck. However, I think you want to test that the generated expression is actually as expected instead.
> If you want to test for "non-crash", remove the FileCheck.

Ah, should have known, thanks.

> I think you want to test that the generated expression is actually as expected instead.

There's nothing to test (aside from not crashing): `-alignment-from-assumptions` doesn't actually change anything in this test, even if I remove the alignment on the store or up the alignment from the assumption and alloca.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75471/new/

https://reviews.llvm.org/D75471