[PATCH] D76235: [ARM][LowOverheadLoops] Add checks for narrowing

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 12:33:22 PDT 2020


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Cheers, looks good to me.



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:547
+// half retains its previous value.
+static bool retainsPreviousHalf(const MachineInstr &MI) {
+  const MCInstrDesc &MCID = MI.getDesc();
----------------
nit: retainsPreviousHalf -> retainsPreviousHalfElement


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:550
+  uint64_t Flags = MCID.TSFlags;
+  return Flags & ARMII::RetainsPreviousHalf != 0;
+}
----------------
nit, just: 
  return Flags & ARMII::RetainsPreviousHalfElement;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76235/new/

https://reviews.llvm.org/D76235





More information about the llvm-commits mailing list