[PATCH] D76562: [llvm-objcopy] Recognize llvm-strip-$major as a tool name

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 12:33:22 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/tool-name.test:32
+
+# RUN: llvm-install-name-tool --help | FileCheck --check-prefix=INSTALL %s
+# RUN: %t/llvm-install-name-tool-11 --help | FileCheck --check-prefix=INSTALL %s
----------------
jhenderson wrote:
> I would expect this to have the same set of cases as the other tools. I don't see why they are unique, just because it's emulating the install_name_tool.
Rearranged the tests. Hope that will provide sufficient coverage without being verbose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76562/new/

https://reviews.llvm.org/D76562





More information about the llvm-commits mailing list