[PATCH] D76598: [GlobalISel] support narrow G_IMPLICIT_DEF for DstSize % NarrowSize != 0

[Dominik Montada via Phabricator via llvm-commits]

gargaroff updated this revision to Diff 252093.
gargaroff marked 2 inline comments as done.
gargaroff added a comment.
Herald added subscribers: kerbowa, nhaehnle, jvesely.

Address review comments. Rebase.

@arsenm One of the tests that you added (G_IMPLICIT_DEF s1025) produces more than 9000 lines of code before it eventually fails due to a s65600 G_MERGE_VALUES (nope, not a typo). Since I didn't think it would be feasible to have more than 18000 CHECK-lines for just one test (output slightly differs between both RUN lines), I extracted this test to an extra file and only check for the error message. I hope that is alright with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76598/new/

https://reviews.llvm.org/D76598

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-implicit-def-s1025.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-implicit-def.mir
  llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76598.252093.patch
Type: text/x-patch
Size: 9947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200323/7713b3fc/attachment.bin>