[PATCH] D76539: [CodeGenPrepare] Delete intrinsic call to llvm.assume to enable more tailcall

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 09:48:54 PDT 2020


Carrot marked an inline comment as done.
Carrot added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1989-1990
     }
     case Intrinsic::objectsize:
       llvm_unreachable("llvm.objectsize.* should have been lowered already");
     case Intrinsic::is_constant:
----------------
arsenm wrote:
> I would expect like object size/is_constant this would have been lowered already? I do disagree with using unreachable to error on this case though
This is not in my patch.
Do you want me to delete these 2 cases in the same patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76539/new/

https://reviews.llvm.org/D76539





More information about the llvm-commits mailing list