[PATCH] D76135: [MachineLICM] Don't treat cross copies as cheap

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 09:48:33 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetRegisterInfo.h:533
+  /// share the same register file.
+  virtual bool shareSameRegisterFile(const TargetRegisterClass *DefRC,
+                                     unsigned DefSubReg,
----------------
There's no reason for this to be virtual?


================
Comment at: llvm/test/CodeGen/AMDGPU/idiv-licm.ll:276
+; GFX9-NEXT:    v_rcp_iflag_f32_e32 v3, v0
 ; GFX9-NEXT:  BB4_1: ; %bb3
 ; GFX9-NEXT:    ; =>This Inner Loop Header: Depth=1
----------------
This probably is an improvement


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76135/new/

https://reviews.llvm.org/D76135





More information about the llvm-commits mailing list