[PATCH] D76485: [ARM] Fold VMOVrh VLDR to LDRH

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:12961
+        LN0->getMemOperand()->getFlags(), LN0->getAAInfo());
+    DCI.DAG.ReplaceAllUsesOfValueWith(N0.getValue(1), Load.getValue(1));
+    return Load;
----------------
efriedma wrote:
> I'd prefer to do all the replacements here, instead of relying on the caller to do the remaining replacement.  This applies for all combines that are more complicated that replacing one node with another.
OK. I took the existing code from DAGCombine::visitBITCAST (but, you know, adjusted for different sizes). Let me know if the new code looks better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76485/new/

https://reviews.llvm.org/D76485