[PATCH] D76498: [DWARF] Fix v5 debug_line parsing of prologues with many files

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 03:48:22 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor suggestion.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_many_files_v5.s:1
+## A file with many files and directories in a single debug_line contribution
+## meant to test the handling of directory_count and file_name_count fields.
----------------
Perhaps "An object with..." to avoid ambiguity between file/files


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76498/new/

https://reviews.llvm.org/D76498





More information about the llvm-commits mailing list