[PATCH] D76336: [DWARF] Emit DW_AT_call_pc for tail calls

Mon Mar 23 03:15:45 PDT 2020

djtodoro added a comment.

In D76336#1934828 <https://reviews.llvm.org/D76336#1934828>, @vsk wrote:

> Add more detailed comments, and always emit DW_AT_call_pc in DWARF5 mode (even when tuning for GDB).

I like this. Actually, I was for this option.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:873
       const MCSymbol *PCAddr =
           (IsTail && !tuneForGDB())
               ? nullptr
----------------
I still think we can avoid the PCAddr here as `(IsTail && !useGNUAnalogForDwarf5Feature(DD))`, if we want to use the call_pc for  gdb + dwarf5 tunning? 
And also update the comment above.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76336/new/

https://reviews.llvm.org/D76336