[PATCH] D76205: Add support for custom op parser/printer hooks to know about result names.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 22 21:29:20 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/lib/Parser/Parser.cpp:4033
+    size_t count = 0;
+    for (auto &entry : resultIDs)
+      count += std::get<1>(entry);
----------------
FYI: clang-tidy flags this and suggests a `const auto &entry` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76205/new/

https://reviews.llvm.org/D76205





More information about the llvm-commits mailing list