[PATCH] D76564: [ValueTracking] Avoid blind cast from Operator to Instruction

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 22 06:54:51 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1743
+    if (!Shuf)
+      return;
     // For undef elements, we don't know anything about the common state of
----------------
```
if (!Shuf) {
  Known.resetAll();
  return;
}
```



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1802
+    const Value* Vec = I->getOperand(0);
+    const Value* Idx = I->getOperand(1);
     auto *CIdx = dyn_cast<ConstantInt>(Idx);
----------------
clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76564/new/

https://reviews.llvm.org/D76564





More information about the llvm-commits mailing list