[PATCH] D76550: [Attributor] Improve the alignment of the loads

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

You should query the base alignment AA in the initialize once to make sure it exists and is part of the fixpoint iteration. For now that is trivially the case but I can see that this might not be this way in the future.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5638
+          unsigned Alignment =
+              AlignAA.getKnownAlign() == 0 ? 1 : AlignAA.getKnownAlign();
+          createReplacementValues(Alignment, PrivatizableType.getValue(), ACS,
----------------
I think you can take the assumed alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76550/new/

https://reviews.llvm.org/D76550