[PATCH] D74877: [clang] fix incorrect Wdocumentation fix-its

[Mark de Wever via Phabricator via llvm-commits]

Mordante added a comment.

Sorry it took a while.

Do you want to continue this patch or switch to the other one as you mentioned before?

Some other remarks:

- In the tests please include the exact issues mentioned in PR43755 and PR43808.
- I'd also like the patch to be a bit more robust regarding the fix-its. @gribozavr2 also offered some suggestions:
  - Take all `\param`s and function parameters in account when looking for a solution and find the best total solution.
  - If the edit distance is too large don't use that suggestion.
  - Since most people tend to document `\param`s in the same order as the function parameters you can also take that into account.

Can you add a few more complex test cases, for example something like:

  /**
   * \param aabb X
   * \param abbb Y
   */
  void foo(int NotMe, int bbbb);

Which comment will be attached to `bbbb`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74877/new/

https://reviews.llvm.org/D74877