[PATCH] D76540: [InstCombine] Remove ExpensiveCombines option

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: spatel, lebedev.ri.
Herald added subscribers: llvm-commits, arphaman.
Herald added a project: LLVM.

D75801 <https://reviews.llvm.org/D75801> removed the last and only user of this option, so we can drop it now. The original idea behind this was to only run expensive transforms under `-O3`, but apart from the one known bits transform, this has never really taken off. I believe nowadays the recommendation is to put expensive transforms in `AggressiveInstCombine` instead, though that isn't terribly popular either :)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76540

Files:
  include/llvm/Transforms/IPO/PassManagerBuilder.h
  include/llvm/Transforms/InstCombine/InstCombine.h
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/InstCombine/InstCombineInternal.h
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/all-bits-shift.ll
  test/Transforms/InstCombine/assume.ll
  test/Transforms/InstCombine/call-returned.ll
  test/Transforms/InstCombine/expensive-combines.ll
  test/Transforms/InstCombine/known-bits.ll
  test/Transforms/InstCombine/known-signbit-shift.ll
  test/Transforms/InstCombine/out-of-bounds-indexes.ll
  test/Transforms/InstCombine/phi-shifts.ll
  test/Transforms/InstCombine/pr44541.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76540.251828.patch
Type: text/x-patch
Size: 21021 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200321/1781a31e/attachment.bin>