[PATCH] D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC.

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 15:12:49 PDT 2020


stefanp marked an inline comment as done.
stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:563
+  // case adds the @notoc as required.
+  case PPC::BL8_NOTOC: {
+    const MachineOperand &MO = MI->getOperand(0);
----------------
nemanjai wrote:
> It seems kind of surprising that we do not need to do anything special here for the existing versions of `BL8/BL8_NOP/BL8_TLS/...` but we do need it for this. Can you explain why that is?
You are correct. I do not actually need this code here. I have changed the patch and I think it looks better now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73664/new/

https://reviews.llvm.org/D73664





More information about the llvm-commits mailing list