[PATCH] D76524: IfOP - Add a builder with result operands

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:226
+    OpBuilder<"Builder *builder, OperationState &result, "
+              "ArrayRef<Type> resultTypes, Value cond, "
+              "bool withElseRegion">
----------------
nit: Can you use TypeRange here instead of ArrayRef?


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:204
                  bool withElseRegion) {
+  build(builder, result, llvm::None, cond, withElseRegion);
+}
----------------
nit: Can you add a /*...=*/ comment to the llvm::None?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76524/new/

https://reviews.llvm.org/D76524