[PATCH] D76523: [GlobalISel] Combine G_SELECTs of the form (cond ? x : x) into x

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 14:40:04 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-select.mir:4-5
+
+...
+---
+name:            self
----------------
paquette wrote:
> also I found out that apparently update_mir_test_checks doesn't like it when this isn't here which is weird. It will skip the function entirely.
I think there's an off by one. Usually the first line is ---, and ends with ....


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76523/new/

https://reviews.llvm.org/D76523





More information about the llvm-commits mailing list