[PATCH] D76519: [NFC] Refactor how CFI move sections are represented in AsmPrinter

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 12:28:48 PDT 2020


scott.linder created this revision.
Herald added subscribers: llvm-commits, hiraditya, aprantl.
Herald added a project: LLVM.
scott.linder added reviewers: dcandler, aprantl, joerg, tyomitch.

AsmPrinter didn't directly represent the possibility of needing both
.eh_frame and .debug_frame, even though it is possible with
-force-dwarf-frame-section. Switch to representing it as bitflags, and
just cache the set of sections needed for the module rather than
handling the no-EH case specially.

It seems like this could all get moved to MachineFunction, especially
considering MachineFunction::needsFrameMoves should really be
referencing it, but there is some dependency on Function which prevents
that so I stopped here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76519

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/lib/CodeGen/AsmPrinter/ARMException.cpp
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCFIException.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76519.251717.patch
Type: text/x-patch
Size: 6760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200320/617f5fca/attachment-0001.bin>


More information about the llvm-commits mailing list