[PATCH] D76517: D52896, D52898 and D52966 merged into LLVM trunk

Fri Mar 20 11:55:35 PDT 2020

jfb requested changes to this revision.
jfb added a comment.
This revision now requires changes to proceed.

I've provided a large amount of feedback on prior iterations of this, and would like to see it addressed.

Most important: I'm still worried that anyone changing IR can introduce miscompiles in function merging because the optimization doesn't know about the new IR properties. This has happened before and will happen again.

I'd also much rather see incremental changes to the existing code than another way to do function merging, with no plan to de-duplicate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76517/new/

https://reviews.llvm.org/D76517