[PATCH] D76460: [mlir] [VectorOps] Introduce vector.transpose on 2-D vectors

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 11:23:30 PDT 2020


aartbik added a comment.

> How do we want to represent permutation? AffineMapAttr or I32ArrayAttr?

If we go the route of general semantics and dimensions, I think arrayattr would the the right syntax

%1 = vector.tranpose %0 [0,1,3,2] : vector<2x3x4x5xf32>

  <----->
    rank-length, all members 0 <= i < rank, proper permutation

It will not be much more work to introduce this syntax, and still verify for proper 2-D transpose (or only lower those for the time being).

WDYT? Right syntax, shall I do it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76460/new/

https://reviews.llvm.org/D76460





More information about the llvm-commits mailing list