[PATCH] D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 09:11:06 PDT 2020


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:801
+
+    if (It == End)
+      return;
----------------
This looks redundant? No, the formatting in phabricator was weird. this belongs to the outer loop. I guess you could pull this into the inner loop and then get rid of the `It != End &&`. Not sure if that is a big improvement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76467/new/

https://reviews.llvm.org/D76467





More information about the llvm-commits mailing list