[PATCH] D76499: [obj2yaml] - Simplify and reduce `ELFDumper<ELFT>::dumpSections`. NFCI.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 08:05:32 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:251
+  auto GetDumper = [&, this](unsigned Type)
+      -> std::function<Expected<ELFYAML::Chunk *>(const Elf_Shdr *)> {
+    switch (Type) {
----------------
std::function<...> is not needed. How about returning a pointer to class member function?




This method it a bit too large.
It is becoming inconvenient to update it.
This patch suggests a way to reduce and cleanup it.


https://reviews.llvm.org/D76499

Files:
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76499.251641.patch
Type: text/x-patch
Size: 10248 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200320/6d4ea327/attachment-0001.bin>


More information about the llvm-commits mailing list