[PATCH] D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 05:55:26 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/AArch64/dag-combine-trunc-build-vec.ll:25
+; makes the combine to happen before type legalization and the issue no longer
+; repros.
+  %1 = insertelement <16 x i32> undef, i32 %p, i32 0
----------------
Maybe move this comment above the define like you did below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76312/new/

https://reviews.llvm.org/D76312





More information about the llvm-commits mailing list