[PATCH] D73832: Ignore/Drop droppable uses for code-sinking in InstCombine

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 02:08:15 PDT 2020


nikic added a comment.

Just a general question from my side: In what direction is this heading?

Is this particular transform (InstCombine code sinking) something where assumes were observed to be problematic in practice? Or is this more of a proof-of-concept that will be extended to other one-use checks in InstCombine? (There's a lot of them, and I'm slightly concerned about the amount of boilerplate that would have to be introduced to handle this everywhere.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73832/new/

https://reviews.llvm.org/D73832





More information about the llvm-commits mailing list