[PATCH] D76410: [ELF] Don't combine SHF_LINK_ORDER sections linking different output sections

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

The logic looks reasonable to me. 2 more comments about comments are inlined.
(I think it worth to hold this for a day or too to see if there will be any other comments).



================
Comment at: lld/test/ELF/partition-move-to-main-startstop.s:9
 // some sections being moved out of the __start_/__stop_ range. Make sure that
 // that didn't happen by checking that there is only one section.
 //
----------------
This should be rewritten too. "there is only one section" is not true, and
"We can't let the has_startstop section be split by partition" sounds like we should not split `has_startstop` at all.



================
Comment at: lld/test/ELF/partition-move-to-main-startstop.s:12
 // It's fine for us to split no_startstop because of the lack of
 // __start_/__stop_ symbols.
 
----------------
And this one looks like it is fine to split "no_startstop", but it assumes it is not true for "has_startstop"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76410/new/

https://reviews.llvm.org/D76410