[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support

Thu Mar 19 23:57:44 PDT 2020

skan marked an inline comment as done.
skan added inline comments.

================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:10
+  # We should not increase the length of this jmp to reduce the bytes of
+  # following nops, doing so would make the jmp misaligned.
+# CHECK:      18:          jmp
----------------
LuoYuanke wrote:
> skan wrote:
> > reames wrote:
> > > This case should already be handled by skipping instructions past the branch align.
> > No, it's not handled.  Your can run this test case without this patch to prove.
> Do you mean when jmp size is expanded, it cross the align boundary? That seems a problem. The jmp size should be frozen after nop padding.
Yes, the jump's size is expanded and leans against the boundary. This patch is trying to fix this bug.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76285/new/

https://reviews.llvm.org/D76285