[PATCH] D75799: [JumpThreading] Don't create PHI nodes with "is.constant" values

Bill Wendling via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 21:54:57 PDT 2020


void added a comment.

In D75799#1932597 <https://reviews.llvm.org/D75799#1932597>, @joerg wrote:

> Yes, __builtin_expect is just noise here. The point I wanted to make is that both sz and bytes should be used in __builtin_constant_p in the other condition.


I'm sorry, but I still don't see why. And I don't see how we can enforce that rule.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75799/new/

https://reviews.llvm.org/D75799





More information about the llvm-commits mailing list