[PATCH] D76457: [InstCombine] Don't replace musttail result based on known bits
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 19 18:07:36 PDT 2020
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for following up on this.
> I was wondering whether we should be preventing this somehow directly in computeKnownBits(), but it seemed pretty odd to me to add a check in the analysis to return a worse result if musttail is used...
I don't think so, your approach is better. Other users of `computeKnownBits` might be able to use the result even though it is a returned must-tail call, e.g., if the user is inter-procedrual.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76457/new/
https://reviews.llvm.org/D76457
More information about the llvm-commits
mailing list