[PATCH] D76442: [mlir/quant] fix a small typo in the quant utility

Feng Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 12:00:11 PDT 2020


liufengdb created this revision.
liufengdb added a reviewer: stellaraccident.
Herald added subscribers: llvm-commits, Joonsoo, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.

This is an edge case where the input type is a primitive type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76442

Files:
  mlir/lib/Dialect/Quant/Utils/UniformSupport.cpp


Index: mlir/lib/Dialect/Quant/Utils/UniformSupport.cpp
===================================================================
--- mlir/lib/Dialect/Quant/Utils/UniformSupport.cpp
+++ mlir/lib/Dialect/Quant/Utils/UniformSupport.cpp
@@ -46,8 +46,8 @@
 
   switch (inputType.getKind()) {
   default:
-    if (isQuantizablePrimitiveType(elementalType)) {
-      // For primitives, just use the new elemental type.
+    if (elementalType.getExpressedType() == expressedType) {
+      // If the expressed types match, just use the new elemental type.
       return elementalType;
     }
     // Unsupported.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76442.251430.patch
Type: text/x-patch
Size: 598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200319/ed3e8dbc/attachment.bin>


More information about the llvm-commits mailing list