[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 10:54:47 PDT 2020


dsanders added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:159
+      else
+        Flags.setOrigAlign(Align(1));
+
----------------
You shouldn't need to drop all the way down to align 1 for the subsequent parts. For example if we start with 8 byte alignment, an offset of 4 leaves us with 4 bytes alignment. commonAlignment(Align A, uint64_t Offset) should compute it for you


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808





More information about the llvm-commits mailing list