[PATCH] D75131: [llvm-objdump][XCOFF][AIX] Implement -r option

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 10:52:32 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:22
+enum : uint16_t { NO_REL_MASK = 0x0001 };
+} // namespace
 
----------------
Is the anonymous namespace useful?


================
Comment at: llvm/test/tools/llvm-objdump/xcoff-disassemble-all.test:1
-# RUN: llvm-objdump -D %p/Inputs/xcoff-section-headers.o | \
+# RUN: llvm-objdump -D -r %p/Inputs/xcoff-section-headers.o | \
 # RUN: FileCheck %s
----------------
Rebase and move it to XCOFF/disassemble-all.test

The hierarchy of llvm-objdump test files follows llvm-readobj/llvm-objcopy now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131





More information about the llvm-commits mailing list