[PATCH] D76248: Fix a bug in the legacy inliner that causes subseqeunt double inlining.

Thu Mar 19 09:45:59 PDT 2020

hoyFB added a comment.

In D76248#1931511 <https://reviews.llvm.org/D76248#1931511>, @wenlei wrote:

> Thanks for fixing this! I forgot to ask earlier, but this could happen with inlining under new PM as well, right? With new PM, we collect calls within SCC, then iterate over them for inlining, so for the same reason we could have dangling call in `VMap` from cloning?

Yes, it could, though that didn't happen in our case. I think it's due to different orders calls are processed in the legacy and new inliner.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76248/new/

https://reviews.llvm.org/D76248