[PATCH] D76363: [MLIR] Add parallel loop coalescing.
Theodore Popp via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 19 06:59:50 PDT 2020
tpopp marked 2 inline comments as done.
tpopp added inline comments.
================
Comment at: mlir/lib/Transforms/Utils/LoopUtils.cpp:1163
+
+ Value iv = (idx == e - 1)
+ ? previous
----------------
tpopp wrote:
> herhut wrote:
> > It would read easier for me if updating previous was also done here except for the last case. Would that make sense?
> I think this trades one mess for a different one because then it's just a different bounds check and not all indexing is happening at ivar_idx anymore.
I tried to restructure it to be more readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76363/new/
https://reviews.llvm.org/D76363
More information about the llvm-commits
mailing list