[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 05:21:52 PDT 2020


Higuoxing added a comment.

In D76081#1930893 <https://reviews.llvm.org/D76081#1930893>, @grimar wrote:

> This need test cases I think.


Seems that we don't have any test on `sh_size % sizeof(Elf_Sym) != 0`. Do you have any suggestion on crafting such test?
There are 3 tools using this method: `llvm-nm`, `llvm-objdump`, `llvm-cxxdump`. I think we could write unit test for this in `llvm-nm` or `llvm-objdump` folder. What's your opinion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081





More information about the llvm-commits mailing list