[PATCH] D76399: [WebAssembly] SIMD integer abs instructions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 03:45:07 PDT 2020


aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:130
+    for (auto T : {MVT::v16i8, MVT::v8i16, MVT::v4i32})
+      setOperationAction(ISD::ABS, T, Legal);
+
----------------
Out of curiosity, before this patch, how was `ISD::ABS` lowered, given that there's no mention of lowering `ABS` in this file? If it was expanded, wasn't something like `setOperationAction(ISD::ABS, T, Expand)` supposed to be in this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76399/new/

https://reviews.llvm.org/D76399





More information about the llvm-commits mailing list