[PATCH] D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target

Yuta Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 03:11:30 PDT 2020


kateinoigakukun added a comment.

In D76049#1929547 <https://reviews.llvm.org/D76049#1929547>, @dschuff wrote:

> I think the calling convention should be documented since it is basically the core of the swift ABI (even if you don't want to consider it stable yet). So at minimum there should be more explanation in the commit message and there should probably be a doc about the Swift ABI in https://github.com/WebAssembly/tool-conventions/ like there is for C.


Right, I updated the description of this patch for more explanation and I'll create doc about Swift ABI on WebAssembly in https://github.com/WebAssembly/tool-conventions.

> Fortunately for functions that are not public or exported, I believe Binaryen should be able to optimize away the extra arguments after linking, so if you're not using it in your toolchain yet, you should.

Thanks for your information! I'll try it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76049/new/

https://reviews.llvm.org/D76049





More information about the llvm-commits mailing list