[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 251301.
Higuoxing added a comment.

Addressed comments.

- Move `printCOFFSymbol()` out of `if (!DumpDynamic)` scope.
- > @grimar: I think lets create a printSymbol(SymbolRef Sym, ...) helper. It should help.

  Can we do this in next few patches? It seems that we have to resolve some `continue;` and `break;` statements.

- Correct usage of `reportWarning()` (e.g. lower-case first letter, remove `'\n'` and trailing full stop.)
- Add test for `reportWarning()`
- Add `--strict-whitespace` option for `FileCheck`
- Add `CHECK-EMPTY` to ensure no more symbols are printed.
- Remove useless `Section: .data` field in YAML.
- Correct some checking prefix (e.g. NOT-NULL, EMPTY).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/test/tools/llvm-objdump/X86/elf-dynamic-symbols.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75756.251301.patch
Type: text/x-patch
Size: 9494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200319/b4b03746/attachment.bin>