[PATCH] D74169: [WIP][LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info.

Thu Mar 19 01:03:37 PDT 2020

grimar added a comment.

In D74169#1928711 <https://reviews.llvm.org/D74169#1928711>, @avl wrote:

> @ruiu, @grimar, @MaskRay
>
> While working on "remove obsolete debug info in lld" patch 
>  I need to generate the DWARF section contents. dsymutil 
>  uses AsmPrinter to create DWARF. Thus to create things 
>  in the same way, I need to  add AsmPrinter library and targets libraries:
>
>   --- a/lld/ELF/CMakeLists.txt
>   +++ b/lld/ELF/CMakeLists.txt
>   @@ -59,6 +59,10 @@ add_lld_library(lldELF
>      Option
>      Passes
>      Support
>   +  AllTargetsCodeGens
>   +  AllTargetsDescs
>   +  AllTargetsInfos
>   +  AsmPrinter
>  
>
>
> Would it be OK to add these libraries to lld code ?
>
> If that is not OK, then alternative solution would be to refactor 
>  DWARF generation code to remove dependence on AsmPrinter and friends.

Honestly I just do not know the answer, but it sounds to me that we can add them, and do
the refactoring you are proposing after whole functionality is done. (i.e. remove them later if it will be possible/reasonable).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74169/new/

https://reviews.llvm.org/D74169