[PATCH] D76403: Add Builder::get{I32,I64}TensorAttr.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 00:30:43 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/Builders.h:119
 
+  /// Vector-typed DenseIntElementsAttr getters. `values` cannot be empty.
   DenseIntElementsAttr getI32VectorAttr(ArrayRef<int32_t> values);
----------------
nit: cannot -> must not


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76403/new/

https://reviews.llvm.org/D76403





More information about the llvm-commits mailing list